Re: [update] net/snort 2.9.20

On 2022/08/29 23:39, Markus Lude wrote:
> On Wed, Aug 24, 2022 at 03:15:49PM +0100, Stuart Henderson wrote:
>
> Hi,
>
> > commited, thanks. diff was against an old tree so hand-applied
> > rather than patch(1)'d.
>
> sorry for the additional work. I seem to have missed this.
>
> Unfortunately some additional change crept in. The PLIST entry of
> lib/snort_dynamicrules got lost. Normally the directory is empty and a
> placeholder for compiled rules. The directory is referenced in
> /etc/snort/snort.conf:
>
> 256
> 257 # path to dynamic rules libraries
> 258 dynamicdetection directory /usr/local/lib/snort_dynamicrules
> 259
>
> and snort now complains about the missing directory.
> Therefore either comment out the line in snort.conf or as I prefer
> re-add back the entry in PLIST.
>
> Attached is a patch for the later way.

I've committed this plus a change so the directory does actually get
created in post-install, otherwise the PLIST references a directory
which doesn't exist.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/snort/Makefile,v
> retrieving revision 1.114
> diff -u -p -u -p -r1.114 Makefile
> --- Makefile 24 Aug 2022 14:14:57 -0000 1.114
> +++ Makefile 29 Aug 2022 20:51:35 -0000
> @@ -1,6 +1,7 @@
> COMMENT = highly flexible sniffer/NIDS
>
> DISTNAME = snort-2.9.20
> +REVISION = 0
> RULESV = 29200
> SUBST_VARS = RULESV APPID_COMMENT
>
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/net/snort/pkg/PLIST,v
> retrieving revision 1.37
> diff -u -p -u -p -r1.37 PLIST
> --- pkg/PLIST 24 Aug 2022 14:16:28 -0000 1.37
> +++ pkg/PLIST 29 Aug 2022 20:51:35 -0000
> @@ -45,6 +45,7 @@ ${APPID_COMMENT}@so lib/snort_dynamicpre
> @so lib/snort_dynamicpreprocessor/libsf_ssh_preproc.so
> @comment lib/snort_dynamicpreprocessor/libsf_ssl_preproc.la
> @so lib/snort_dynamicpreprocessor/libsf_ssl_preproc.so
> +lib/snort_dynamicrules/
> @man man/man8/snort.8
> share/doc/pkg-readmes/${PKGSTEM}
> share/doc/snort/