"make update-plist" doesn't add the .orig files to the PLIST anyway. It's
ok to rm if you want to avoid the warning message, but please use
"${PATCHORIG}" not ".orig" in the rm.
--
Sent from a phone, apologies for poor formatting.
On 26 October 2022 09:27:24 "Kirill Bychkov" <kirby@linklevel.net> wrote:
> On Tue, October 25, 2022 22:30, Stuart Henderson wrote:
>> On 2022/10/24 17:29, Omar Polo wrote:
>>> On 2022/10/15 22:27:46 +0300, "Kirill Bychkov" <kirby@linklevel.net> wrote:
>>> > On Sun, May 15, 2022 16:06, wen heping wrote:
>>> > > It could be build with root privilege, failed with unprivilege user.
>>> >
>>> > Hi,
>>> > Limits were the cause of breaking sigil build. Setting stacksize-cur=8M in
>>> > login.conf allows me to build it without issues on amd64. I can say more:
>>> > sigil-1.4.3 fails on -current without bumping limits. So the diff Wen sent
>>> was
>>> > good enough. Since then sigil-1.9.20 was released. It also needs stacksize
>>> > bump. Launches without issues on amd564. Updated diff attached.
>>>
>>> sorry for the delay,
>>>
>>> not a sigil user, but it now builds fine and runs fine (i can click
>>> around in the gui, the editor seem to work.)
>>>
>>> patch-CMakeLists_txt needs a regen, and `make package' complains that:
>>>
>>> Warning: entries NOT added to sigil-1.9.20:
>>> share/sigil/python3lib/updatechecker.py.orig (.orig suffix ?)
>>>
>>> (maybe it did it in the past too)
>>>
>>> not a huge issue, but i don't know if it's preferred to delete
>>> .${PATCHORIG} files in pre-install or just leave make package ignore
>>> them.
>>
>> either way works (but if rm'ing, please do use ${PATCHORIG} rather
>> than hardcoding, so that it doesn't fail for people who have set
>> PATCHORIG to something else in /etc/mk.conf)
>>
>>
> Hi,
> We are patching updatechecker.py to disable update checks, so
> share/sigil/python3lib/updatechecker.py.orig is recursively installed.
> I've added
> post-install:
> rm ${PREFIX}/share/sigil/python3lib/updatechecker.py.orig
> to fix that issue.
> CMakeLists.txt patch regened. If there is no other comments I will
> commit this update soon.
> BTW. Do we need any #XXX about bumping stacksize-cur=8M for those who
> is not using dbp?
No comments:
Post a Comment