Re: [update] net/synapse 1.68.0 | devel/matrix-common-1.3.0

On 10/5/22 13:16, Landry Breuil wrote:
> Le Thu, Sep 29, 2022 at 09:09:10AM +0200, Renaud Allard a écrit :
>>
>>
>> On 9/28/22 16:20, Stuart Henderson wrote:
>>>> hum, it seems COMPILER_LIBCXX is right even for sparc64.
>>>>
>>>> on sparc64, devel/llvm is linked against estdc++. as rustc uses the devel/llvm
>>>> libraries, it is using also estdc++. so COMPILER_LIBCXX is the right thing to
>>>> use here.
>>>
>>> Oh, perhaps it's the other ports which are wrong on sparc64 then...
>>>
>>
>> So, this one should be good
>
> coming back to this:
>
>> - devel/py-matrix-common${MODPY_FLAVOR}>=1.2.1 \
>> + devel/py-matrix-common${MODPY_FLAVOR}<2.0.0 \
>
> i think it should be >=1.3.0,<2.0.0 otherwise if you have 1.2.1 it will
> happily go with it.

It depends on how you look at it. If you read Stuart's comment, and look
at it like a package which will be updated with pkg_add, then <2.0.0 is
sufficient since devel/py-matrix-common will be updated at the same time
(assuming it is committed together like it should). However, if you look
at it now, uncommitted, then yes, this can cause issues with the 1.2.1
package.

>
> on another note, tests fails:
> ImportError while importing test module '/usr/obj/ports/synapse-1.68.0/synapse-1.68.0/tests/server_notices/test_resource_limits_server_notices.py'.
> Hint: make sure your test modules/packages have valid Python names
> Traceback:
> /usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
> return _bootstrap._gcd_import(name[level:], package, level)
> tests/server_notices/test_resource_limits_server_notices.py:18: in <module>
> from synapse.api.constants import EventTypes, LimitBlockingTypes, ServerNoticeMsgType
> synapse/__init__.py:23: in <module>
> from synapse.util.rust import check_rust_lib_up_to_date
> synapse/util/rust.py:20: in <module>
> from synapse.synapse_rust import get_rust_file_digest
> E ModuleNotFoundError: No module named 'synapse.synapse_rust'

This doesn't really affect the package itself afaik, but, indeed, it
should be looked at.

>
> while it works in a python3 cli:
>
> [13:11] c64:~/mystuff/net/synapse/ $python3
> Python 3.9.14 (main, Sep 20 2022, 08:07:29)
> [Clang 13.0.0 ] on openbsd7
> Type "help", "copyright", "credits" or "license" for more information.
>>>> import synapse.synapse_rust
>>>>
>
> Landry
>