Wednesday, December 28, 2022

MODGO_VERSION in modules.inc (was Re: [Maintainer Update] security/age 1.1.1)

On Wed, 28 Dec 2022 13:15:11 +0000, Stuart Henderson
<stu@spacehopper.org> wrote:

> On 2022/12/28 13:13, Theo Buehler wrote:
> > On Wed, Dec 28, 2022 at 12:52:50PM +0100, Volker Schlecht wrote:
> > > Updates security/age to version 1.1.1
> > > https://github.com/FiloSottile/age/releases/tag/v1.1.1
> > >
> > > Tested on amd64.
> >
> > Committed without MODGO_VERSION in modules.inc. Thanks
>
> should we do something like this?
>
> Index: modgo-gen-modules-helper
> ===================================================================
> RCS file: /cvs/ports/infrastructure/bin/modgo-gen-modules-helper,v
> retrieving revision 1.3
> diff -u -p -r1.3 modgo-gen-modules-helper
> --- modgo-gen-modules-helper 3 Jul 2021 02:37:46 -0000
> 1.3 +++ modgo-gen-modules-helper 28 Dec 2022 13:14:15 -0000
> @@ -44,6 +44,6 @@ my $portinfo = $port->get_dist_info($mod
> $port->set_other( MODGO_MODULES => "\\\n" . join(" \\\n",
> @{$portinfo->{Dist}})) if $portinfo->{Dist}; $port->set_other(
> MODGO_MODFILES => "\\\n" . join(" \\\n", @{$portinfo->{Mods}})) if
> $portinfo->{Mods}; -say "MODGO_VERSION =\t$portinfo->{Version}\n";
> +say "MODGO_VERSION =\t$portinfo->{Version} # add this to Makefile,
> not modules.inc\n"; say "MODGO_MODULES =\t$port->{'MODGO_MODULES'}\n"
> if defined($port->{'MODGO_MODULES'}); say "MODGO_MODFILES
> =\t$port->{'MODGO_MODFILES'}\n" if defined($port->{'MODGO_MODFILES'});
>

I personally do `make modgo-gen-modules > modules.inc` in which case
I'm not sure it's going to help much. Are you people doing things
differently to update a go port?

No comments:

Post a Comment