Re: audio/ncspot segfaults on -current

On Sat, Jan 28, 2023 at 01:19:49PM +0100, Matthias Schmidt wrote:
> Hi,
>
> I noticed today that audio/ncspot segfaults on a recent -current. I
> have
>
> OpenBSD 7.2-current (GENERIC.MP) #994: Thu Jan 26 20:09:20 MST 2023
> deraadt@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
>
> with the latest ncspot-0.12.0p0. Upon startup it crashes with a
> segmentation fault:
>
> $ egdb /usr/local/bin/ncspot ./ncspot.core

Please apply this in /usr/ports/security/rust-ring, 'make install' and
then rebuild and reinstall ncspot.

Index: Makefile
===================================================================
RCS file: /cvs/ports/security/rust-ring/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Jan 2023 12:56:09 -0000 1.1.1.1
+++ Makefile 28 Jan 2023 12:24:38 -0000
@@ -2,6 +2,7 @@ COMMENT = ring crate source patched for

VERSION = 0.16.20
DISTNAME = ring-${VERSION}
+REVISION = 0

MASTER_SITES = https://crates.io/api/v1/crates/

Index: patches/patch-pregenerated_sha256-x86_64-elf_S
===================================================================
RCS file: patches/patch-pregenerated_sha256-x86_64-elf_S
diff -N patches/patch-pregenerated_sha256-x86_64-elf_S
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-pregenerated_sha256-x86_64-elf_S 28 Jan 2023 12:24:26 -0000
@@ -0,0 +1,19 @@
+Index: pregenerated/sha256-x86_64-elf.S
+--- pregenerated/sha256-x86_64-elf.S.orig
++++ pregenerated/sha256-x86_64-elf.S
+@@ -1735,6 +1735,7 @@ GFp_sha256_block_data_order:
+ .byte 0xf3,0xc3
+ .cfi_endproc
+ .size GFp_sha256_block_data_order,.-GFp_sha256_block_data_order
++.rodata
+ .align 64
+ .type K256,@object
+ K256:
+@@ -1778,6 +1779,7 @@ K256:
+ .long 0xffffffff,0xffffffff,0x03020100,0x0b0a0908
+ .long 0xffffffff,0xffffffff,0x03020100,0x0b0a0908
+ .byte 83,72,65,50,53,54,32,98,108,111,99,107,32,116,114,97,110,115,102,111,114,109,32,102,111,114,32,120,56,54,95,54,52,44,32,67,82,89,80,84,79,71,65,77,83,32,98,121,32,60,97,112,112,114,111,64,111,112,101,110,115,115,108,46,111,114,103,62,0
++.previous
+ .type GFp_sha256_block_data_order_ssse3,@function
+ .align 64
+ GFp_sha256_block_data_order_ssse3: