Re: i386.ports.openbsd.org build report

Am Sat, 25 Feb 2023 17:20:15 +0100
schrieb Omar Polo <op@omarpolo.com>:

> On 2023/02/25 14:45:58 +0000, Stuart Henderson <stu@spacehopper.org>
> wrote:
> > bulk build on i386.ports.openbsd.org
> > started at 1677208976 Thu Feb 23 20:22:56 MST 2023
> > finished at 1677334037 Sat Feb 25 07:07:17 MST 2023
> > report generated at 1677334068 Sat Feb 25 07:07:48 MST 2023
> > total 34h44m
> > done with kern.version=OpenBSD 7.2-current (GENERIC.MP) #0: Thu Feb
> > 23 19:56:33 MST 2023
> >
> > built packages
> > build failures: 5
> > not built: 0
> > games/openttd
>
> it links sdl2 statically. This should make it package properly, but
> would be nice to dynamically link to it. I couldn't find the right
> cmake incantation to do so. If you're curious, CMakeLists.txt has
>
> link_package(SDL2 TARGET SDL2::SDL2)
>
> where `link_package' is defined in cmake/LinkPackage.cmake and is a
> thin wrapper around CMake' target_link_libraries.

Thank you for looking at it. I'm fine with the diff and I will look
into CMake later.

> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/games/openttd/Makefile,v
> retrieving revision 1.80
> diff -u -p -r1.80 Makefile
> --- Makefile 23 Feb 2023 19:46:44 -0000 1.80
> +++ Makefile 25 Feb 2023 16:17:27 -0000
> @@ -3,6 +3,7 @@ COMMENT= open source clone of the game T
> V = 13.0
> DISTNAME = openttd-$V-source
> PKGNAME = openttd-$V
> +REVISION = 0
>
> CATEGORIES= games
>
> @@ -33,6 +34,9 @@ LIB_DEPENDS= archivers/lzo2 \
> graphics/png \
> textproc/icu4c \
> archivers/xz
> +
> +# statically linked
> +LIB_DEPENDS += devel/sdl2
>
> RUN_DEPENDS = audio/timidity \
> devel/desktop-file-utils \
>

Thanks again!


--
greetings,

Florian Viehweger