On Fri, Mar 10, 2023 at 12:08:52AM +0100, Alexander Bluhm wrote:
> On Wed, Mar 08, 2023 at 02:21:45AM +0000, wen heping wrote:
> > Here is a patch to create 2 new ports:devel/p5-DateTime-Format-Oracle
> > and converters/p5-Convert-NLS_DATE_FORMAT. Both are required by the
> > update of databases/p5-Rose-DB.
> > Both new port build well and pass all tests on amd64-current system.
Attached is a fixed version of the port.
ok?
bluhm
> The files in your tgz have no read permissions for group or others.
> This breaks PORTS_PRIVSEP = yes and should be fixed before commit.
> chmod -R go+rX
>
> COMMENT = Convert Oracle NLS_DATE_FORMAT <-> strftime Format Strings
> comment should start with lower case
> I would not use funky charakters like < and > in comment
>
> COMMENT = Parse and format Oracle dates and timestamps
> comment should start with lower case
>
> RUN_DEPENDS = converters/p5-Convert-NLS_DATE_FORMAT \
> use converters/p5-Convert-NLS_DATE_FORMAT>=0.03 like in Makefile.PL
>
> p5-DateTime-Format-Oracle PLIST
> remove ${P5SITE}/DateTime/ and ${P5SITE}/DateTime/Format/, they are
> already included by run dependency.
>
> apart from that OK bluhm@
No comments:
Post a Comment