Re: [new] sysutils/lsblk

Hello,

On 2023/05/30 17:28:00 +0200, Benjamin Stürz <benni+openbsd@stuerz.xyz> wrote:
> Hi ports@,
>
> lsblk(8) is a simple tool to list attached block devices.
> This specifically is a clone of the one in util-linux.
>
> This is actually my second attempt of submitting this port.
> This time I reworked most of it, fixed all bugs (hopefully :),
> incorporated feedback, added a few options and a manual,
> and added support for RAID through bio(4).
> I think it's ready for submission into the ports tree.
>
> I don't have any commit rights,
> so if you are interested in committing this,
> please let me know.
>
> Testing and comments are appreciated.
>
> WWW: https://git.stuerz.xyz/openbsd/lsblk

I remember that when I started using OpenBSD I kind of missed lsblk...
Now I wouldn't look back probably, but it could be nice for newcommers
(at least :-)

Bummer that it needs superuser privileges to show the list, but I
haven't looked at how it's implemented so don't know.

The port itself looks fine to me, except for the permissions of
distinfo and PLIST... All files should be 0644 and directories 0755.
No need to send an updated tarball just for this however, whoever will
import it can easily fix it.

OK op@ to import with perms fixed.

Now, some misc nits that don't really affect the port:

- you could set yourself as MAINTAINER for the port. It is not
required of course, but seems you seem to be the upstream too
you're qualified enough I'd say ;-)

- I'd drop -Werror from release tarballs. While it is super-useful
during development, it is a super-pita for packagers when the C
compiler gets updated.


Cheers,

Omar Polo