Thursday, August 03, 2023

Re: [fixbug] devel/valgrind: display symblo

On 2023/08/03 16:11:46 +0900, Masato Asou <asou@soum.co.jp> wrote:
> Hi,
>
> I have solved the problem of Valgrind not displaying function names
> and file names when it detects a problem.
>
> [...]
>
> comments, ok?

it's missing a REVISION bump in the Makefile since the content of the
package changes.

other than this, while the changes are a bit over my head, I've
quickly tested it and it seems to be working. So, fwiw, OK op@.

I still get some ??? entries, for example with grep:

$ make clean obj
[...]
$ make DEBUG='-O0 -g3'
[...]
$ valgrind obj/grep foo Makefile
[...]
==31128== Use of uninitialised value of size 8
==31128== at 0x49D935D: ??? (in obj/grep)
==31128== by 0x10F385: grep_reallocarray (util.c:615)
==31128== by 0x10D626: add_pattern (grep.c:186)
==31128== by 0x10D426: add_patterns (grep.c:224)
==31128== by 0x10D03C: main (grep.c:473)
[...]

but it's already so much better :-)


Thanks,

Omar Polo

No comments:

Post a Comment