On 2023/10/31 06:40, Klemens Nanni wrote:
> 20.10.2023 05:05, Renato Aguiar пишет:
> > Here is a port of graphics/nanosvg which will be used later as build
> > dependency for cad/prusaslicer 2.6.1.
> >
> > pkg/DESCR:
> >
> > NanoSVG is a simple stupid single-header-file SVG parse. The output of the
> > parser is a list of cubic bezier shapes.
> >
> > The library suits well for anything from rendering scalable icons in
> > your editor
> > application to prototyping a game.
>
> GH_* sets HOMEPAGE already, tarball has no tests so NO_TEST=Yes.
> With these dropped and added, respectively, OK kn
Standard policy for NO_TEST is not to use it if tests are missing unless
trying to run them results in failure. For just "no tests but doesn't
fail", it's normal not to use it, in case tests get added in a future
update.
> DISTNAME (or just PKGNAME?) could be set from GH_* instead of hardcoding
> the version again.
It's slightly awkward to do here though and it doesn't hurt the way it is.
> Otherwise looks fine port-wise for a tiny static library.
pkg/DESCR is hard up to column 80, I'd rewrap it.
Attached tweaked version is ok with me.
No comments:
Post a Comment