On 2023/11/01 18:26, Miguel Landaeta wrote:
(no need to include two copies of the diff plus a tar; normally we
just use a tar for new ports though one inline copy can be useful for
quoting)
> +MODPY_PI= Yes
> +MODPY_PYBUILD= setuptools
> +MODPY_PYTEST= No
> +MODPY_SETUPUTILS= Yes
> +MODPY_SETUP_ARGS= test
> +SEPARATE_BUILD= Yes
This combination of variables doesn't go together. MODPY_SETUPUTILS and
MODPY_PYBUILD are mutually exclusive (new ports should use MODPY_PYBUILD).
There's a problem with two of icecream tests with pytest but I think it's
best to just note that in a comment rather than try to force using the
deprecated setup.py test runner - https://github.com/gruns/icecream/issues/134
The rest looks good
No comments:
Post a Comment