Sunday, March 03, 2024

Re: pkg_info: fold Comment newline

On 2024/03/02 17:39:10 +0000, Klemens Nanni <kn@openbsd.org> wrote:
> As per Makefile.template and portcheck(1) COMMENT is <=60 chars, so it'd
> fit on the same Comment: line in pkg_info(1) output -- less scrolling!
>
> It just stands out, imho, compared to Maintainer: and WWW: where there's
> no such seemingly superfluous line break.
>
> Thoughts?

I like it! it seems better to me to keep "Comment" and the comment text
in the same line; especially since we strive to have "short" comments.

However, it seems to me that this has the chance of breaking other
tools. Reading this diff I've discovered the -l flag for pkg_info that
is meant to aid parsing the output of pkg_info. I have no clue if this
option is used anywhere, but I'd prefer not to discover it when we're
this close to the release :)

In particular, pkg_info -lxxx quirks will change:

@@ -1,7 +1,6 @@
xxxInformation for inst:quirks-7.10

-xxxComment:
-exceptions to pkg_add rules
+Comment: exceptions to pkg_add rules

No comments:

Post a Comment