Hi,
On Thu, 06 Jun 2024 12:14:56 +0100,
Edd Barrett <edd@theunixzoo.co.uk> wrote:
>
> On Mon, Jun 03, 2024 at 10:54:42PM +0100, Edd Barrett wrote:
> > Some superficial comments below.
>
> Besides audio/beets, there's also audio/pithos that uses py-last. Might be
> worth checking that this isn't broken by the update?
>
I haven't got pandora account and I have no idea how to test it without it.
Anyway, ports has pithos-1.1.2 whcih was released in end of 2015 [1], I
have't find any requried version of pylast and on that time the last
released varions of pylast was 1.4.2 [2]
With an assumtion that both version of compatible I've analyzed which API is
used by that plugin [3] which is quite limited but used method
get_lastfm_network which was removed since release 2.0.0 [4] in 2017.
So, it seems that this update is really broke audio/pithos which is quite
outdated (almost 10 years old!) and the right move is update it.
Footnotes:
[1] https://github.com/pithos/pithos/blob/1.1.2/pithos/plugins/lastfm.py
[2] https://github.com/pylast/pylast/releases/tag/1.4.2
[3] https://github.com/pithos/pithos/blob/1.1.2/pithos/plugins/lastfm.py
[4] https://github.com/pylast/pylast/commit/4a1b50350fab85ca99f8c1780da82f677f6decfb
--
wbr, Kirill
No comments:
Post a Comment