Thursday, September 19, 2024

audio/morseplayer: audio quality fix

Hello,

I found the post that audio quality of audio/morseplayer is something
strange at https://x.com/yoshi_kaw/status/1692411414718419377 .

patches/patch-morseplayer_c sets unsigned 8bit to sio_setpar(),
but original code uses AUDIO_ENCODING_SLINEAR_LE (signed).

This should be fixed.

ok?

Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/morseplayer/Makefile,v
diff -u -p -r1.18 Makefile
--- Makefile 28 Jul 2022 16:52:07 -0000 1.18
+++ Makefile 19 Sep 2024 14:31:05 -0000
@@ -5,7 +5,7 @@ GH_PROJECT= morseplayer
GH_COMMIT= 48f3d0bb07f94acc0328bee932e96c92a56dd133

DISTNAME= morseplayer-1.4
-REVISION= 1
+REVISION= 2
CATEGORIES= audio

HOMEPAGE= https://github.com/wrigjl/morseplayer
Index: patches/patch-morseplayer_c
===================================================================
RCS file: /cvs/ports/audio/morseplayer/patches/patch-morseplayer_c,v
diff -u -p -r1.3 patch-morseplayer_c
--- patches/patch-morseplayer_c 11 Mar 2022 18:20:18 -0000 1.3
+++ patches/patch-morseplayer_c 19 Sep 2024 14:31:05 -0000
@@ -152,7 +152,7 @@
- err(1, "open %s", afname);
+ sio_initpar(&par);
+ par.rate = 22050;
-+ par.sig = 0;
++ par.sig = 1;
+ par.bits = 8;
+ par.pchan = 1;
+ if (!sio_setpar(pars.hdl, &par))

--
SASANO Takayoshi (JG1UAA) <uaa@mx5.nisiq.net>

No comments:

Post a Comment