Re: NEW net/monero

On 2024/11/04 10:22, Stepan Zolotuev wrote:
> > Hi ports,
> >
> > I'd like to import Monero. OK?
> >
> > The CLI works great. The daemon manages to do a full sync, but with lots
> > of serious stalls that rendered the system unusable for a long amount of
> > minutes. Should I add a warning message about that in DESCR or README?
>
> The daemon should probably read configuration from /etc, as per the porting guide,
> file.
>
> There is also some documentation and a template config file in the source tarball,
> which could be worth installing for reference. In my port I implemented
> this (and some other things) like in the diff below.
>
> (I remember getting these from previous ports on this list, my own has it too.)
>
>
> Stepan
>
> diff -ruNp monero/Makefile mymonero/Makefile
> --- monero/Makefile Sun Nov 3 22:13:47 2024
> +++ mymonero/Makefile Sat Nov 2 20:18:01 2024
> @@ -1,48 +1,59 @@
> +post-install:
> + ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/monero
> + ${INSTALL_DATA_DIR} ${WRKINST}${LOCALSTATEDIR}/monero

no point doing that in post-install, the dir is created by the
@sample mechanism

> + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/monero
> + ${INSTALL_DATA} ${WRKSRC}/README.md ${WRKSRC}/docs/*.md\
> + ${PREFIX}/share/doc/monero/
> + ${INSTALL_DATA} ${WRKBUILD}/lib/libwallet.a ${PREFIX}/lib/

is that actually useful? I suggest not unless there's a need for it

> + ${INSTALL_DATA} ${WRKSRC}/utils/conf/monerod.conf\
> + $(PREFIX)/share/examples/monero/
>
> diff -ruNp monero/pkg/monerod.rc mymonero/pkg/monerod.rc
> --- monero/pkg/monerod.rc Sun Nov 3 20:25:07 2024
> +++ mymonero/pkg/monerod.rc Wed Aug 28 22:44:12 2024
> @@ -2,7 +2,7 @@
>
> daemon="${TRUEPREFIX}/bin/monerod"
> daemon_user="_monerod"
> -daemon_flags="--detach"
> +daemon_flags="--detach --config-file ${SYSCONFDIR}/monerod.conf"

I'm not going to run this to test, but presumably --detach is a required
flag for running as a daemon, so it should go as part of "daemon",
leaving the (overridable) --config-file bit in daemon_flags.

> diff -ruNp monero/patches/patch-utils_conf_monerod_conf mymonero/patches/patch-utils_conf_monerod_conf
> --- monero/patches/patch-utils_conf_monerod_conf Thu Jan 1 09:00:00 1970
> +++ mymonero/patches/patch-utils_conf_monerod_conf Fri Aug 30 18:12:53 2024
> @@ -0,0 +1,14 @@
> +Set correct paths in default config file.
> +
> +Index: utils/conf/monerod.conf
> +--- utils/conf/monerod.conf.orig
> ++++ utils/conf/monerod.conf
> +@@ -3,6 +3,6 @@
> + # Boolean options such as 'no-igd' are specified as 'no-igd=1'.
> + # See 'monerod --help' for all available options.
> +
> +-data-dir=/var/lib/monero
> +-log-file=/var/log/monero/monero.log
> ++data-dir=${LOCALSTATEDIR}/monero

/var/db/monero might be better than /var/monero

> ++log-file=${LOCALSTATEDIR}/monero/log

/var/log/monero/monero.log seems a better location (with whatever
PLIST tweaks are needed to create the dir with correct perms)

> + log-level=0