Re: [PATCH] www/mozilla-firefox - fix a couple of typos in the package README

"though, but" is redundant - that line would sound better as "should create this directory, but it won't be available"

"Check if it is enabled" feels a bit clunky, how about "Check that it's enabled"?

+ REVISION bump needed.

-- 

  Sent from a phone, apologies for poor formatting.

On 4 November 2024 10:10:28 Raf Czlonka <rczlonka@gmail.com> wrote:

Hello,

The below diff fixes a couple of typos I found.

Also, I _think_ there's at least one case in the README, where the

name of the software, rather than the binary/port name should be

used, i.e.: a case of "Firefox" vs. "${MOZILLA_PROJECT}"; but, after

going through the file in the CVS, I'm not sure any more. Probably

best if someone goes through the installed/rendered README, rather

than the CVS one, and sees if there's any "firefox" that could do

with capitalising ;^)

Cheers,

Raf

P.S. I'm not subscribed to ports@ mailing list so please CC me if need be.

Index: www/mozilla-firefox/pkg/README

===================================================================

RCS file: /cvs/ports/www/mozilla-firefox/pkg/README,v

diff -u -p -r1.37 README

--- www/mozilla-firefox/pkg/README 29 Oct 2024 12:40:10 -0000 1.37

+++ www/mozilla-firefox/pkg/README 4 Nov 2024 10:00:48 -0000

@@ -27,7 +27,7 @@ ${SYSCONFDIR}/${MOZILLA_PROJECT}/{unveil

 As unveil() can't show non-existing dirs, it is recommended to manually

 create ~/Downloads for files to be properly saved in this directory.

 

-Starting ${MOZILLA_PROJECT} should create this dir though, but it wont be available

+Starting ${MOZILLA_PROJECT} should create this dir though, but it won't be available

 for downloads until it's restarted.

 

 3rd-Party MIME Handlers

@@ -119,7 +119,7 @@ device e.g.:

 

 # chown youruser /dev/video0

 

-Screen sharing needs shmget() which isnt available when pledge() is active, so

+Screen sharing needs shmget() which isn't available when pledge() is active, so

 you will have to disable pledge for the main process.

 

 KerberosV support

@@ -148,7 +148,7 @@ are enabled.

 

 Similarly, the rust-based WebRender compositor can be enabled by setting

 MOZ_WEBRENDER=1 in the environment, or by switching the about:config

-gfx.webrender.enabled knob to true. Check it is enabled in the 'Features'

+gfx.webrender.enabled knob to true. Check if it is enabled in the 'Features'

 section of about:support. For this feature, WebGL2 is necessary, so your

 hardware must support at least OpenGL 4.