Re: [PATCH] www/mozilla-firefox - fix a couple of typos in the package README

On Mon, Nov 04, 2024 at 06:56:07PM GMT, Landry Breuil wrote:
> Le Mon, Nov 04, 2024 at 02:50:09PM +0000, Stuart Henderson a écrit :
> > lgtm.
>
> havent looked at the actual diff, but should it apply as is to
> www/firefox-esr too ?

Yes, at least the README part itself:

$ cd /usr/ports ; cvs diff www/mozilla-firefox/pkg/README | ( cd www/firefox-esr/pkg ; patch )
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: www/mozilla-firefox/pkg/README
|===================================================================
|RCS file: /cvs/ports/www/mozilla-firefox/pkg/README,v
|diff -u -p -r1.37 README
|--- www/mozilla-firefox/pkg/README 29 Oct 2024 12:40:10 -0000
1.37
|+++ www/mozilla-firefox/pkg/README 4 Nov 2024 19:43:57 -0000
--------------------------
Patching file README using Plan A...
Hunk #1 succeeded at 27.
Hunk #2 succeeded at 119.
Hunk #3 succeeded at 148.
done

Which leaves the last paragraph about bitmap fonts:

$ diff www/firefox-esr/pkg/README www/mozilla-firefox/pkg/README
--- www/firefox-esr/pkg/README Mon Nov 4 19:43:57 2024
+++ www/mozilla-firefox/pkg/README Mon Nov 4 14:26:04 2024
@@ -153,3 +153,10 @@
hardware must support at least OpenGL 4.

See https://wiki.mozilla.org/Platform/GFX/Quantum_Render for more details.
+
+Fonts in PDF viewer
+===================
+If using the builtin PDF viewer and you get garbled fonts, bitmap fonts
+should be rejected to fix rendering. A known workaround:
+
+# ln -s /etc/fonts/conf.avail/70-no-bitmaps.conf /etc/fonts/conf.d

REVISION will need a manual bump in www/firefox-esr/Makefile

Cheers,

Raf