Re: sdl2: enable wayland support

Le Sun, Nov 03, 2024 at 01:34:30PM -0500, Thomas Frohwein a écrit :
> Hi,
>
> Proposing this diff which adds wayland support to sdl2. It adds a
> couple of dependencies as expected. I can so far only test that it
> still works in X11 as before. Using wayland for this stumbles over
> libinput limitations with muxing multiple device which my current
> machine sadly depends on...

is it only because you don't have mouse when under wayland ? chown
/dev/wsmouse1 generally helps for me.

> Is someone in a better position to test sdl2 applications in
> wayland/sway etc? Does it make sense to enable it now in sdl2?

i dunno if it "makes sense" by itself, i see no harm. Hadn't tested
running sdl apps within wayland before your patch, but with this sdl2
version, graphics/imv and games/xmoto run within wayfire, and i checked
with xlsclients that they were not listed as X apps started via
xwayland.. imo, sdl2 on top of wayland "works", soo .. ok ? :)

Landry
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/sdl2/Makefile,v
> diff -u -p -r1.61 Makefile
> --- Makefile 3 Nov 2024 13:20:10 -0000 1.61
> +++ Makefile 3 Nov 2024 18:34:03 -0000
> @@ -3,6 +3,8 @@ COMMENT= cross-platform multimedia libra
> V= 2.30.9
> DISTNAME= SDL2-${V}
> PKGNAME= sdl2-${V}
> +REVISION= 0
> +
> CATEGORIES= devel
> SITES= https://www.libsdl.org/release/
>
> @@ -17,13 +19,18 @@ DEBUG_PACKAGES= ${BUILD_PACKAGES}
> # zlib
> PERMIT_PACKAGE= Yes
>
> -WANTLIB+= X11 Xcursor Xext Xfixes Xi Xrandr Xrender Xss iconv m pthread
> -WANTLIB+= samplerate sndio usbhid xcb
> +WANTLIB+= X11 Xcursor Xext Xfixes Xi Xrandr Xrender Xss epoll-shim ffi
> +WANTLIB+= wayland-client wayland-cursor wayland-egl iconv m pthread
> +WANTLIB+= samplerate sndio usbhid xcb xkbcommon
> # GL library is dlopen'd
> WANTLIB+= GL
>
> LIB_DEPENDS= audio/libsamplerate \
> - converters/libiconv
> + converters/libiconv \
> + devel/epoll-shim \
> + devel/libffi \
> + wayland/wayland \
> + x11/xkbcommon
>
> USE_GMAKE= Yes
> SEPARATE_BUILD= Yes
> @@ -42,7 +49,6 @@ CONFIGURE_ARGS+= --disable-alsa \
> --disable-pipewire \
> --disable-pulseaudio \
> --disable-sndio-shared \
> - --disable-video-wayland \
> --disable-video-wayland-qt-touch \
> --disable-wayland-shared \
> --disable-x11-shared
>