Re: mail/procmail CVE-2017-16844

On Wed, Nov 29, 2017 at 06:08:00PM +0100, Landry Breuil wrote:
> On Wed, Nov 29, 2017 at 06:03:31PM +0100, Alexander Bluhm wrote:
> > Hi,
> >
> > +Index: src/formisc.c
> > +--- src/formisc.c.orig
> > ++++ src/formisc.c
> > @@ -84,12 +84,11 @@ normal: *target++= *start++;
> > case '"':*target++=delim='"';start++;
> > }
> > @@ -19,6 +24,15 @@ with unbalanced quotes.
> > }
> > hitspc=2;
> > }
> > +@@ -104,7 +103,7 @@ void loadsaved(sp)const struct saved*const sp; /*
> > + }
> > + /* append to buf */
> > + void loadbuf(text,len)const char*const text;const size_t len;
> > +-{ if(buffilled+len>buflen) /* buf can't hold the text */
> > ++{ while(buffilled+len>buflen) /* buf can't hold the text */
> > + buf=realloc(buf,buflen+=Bsize);
> > + tmemmove(buf+buffilled,text,len);buffilled+=len;
> > + }
>
> Is this the real coding style ?!?!? seriously ?
>

Yes. Quoting guenther@:

"Any whitespace you see is either left-indent, right-indent,
or syntactically required."