Re: new devel/p5-Sub-Attribute

On 11/29/17 12:37, Alexander Bluhm wrote:
> On Wed, Nov 29, 2017 at 02:22:01AM +0100, Jeremie Courreges-Anglas wrote:
>> It looks like you need those in BUILD_DEPENDS, listed "for authors only"
>> in Makefile.PL:
>>
>> devel/p5-Module-Install-AuthorTests \
>> devel/p5-Module-Install-Repository \
>> devel/p5-Module-Install-XSUtil \
>
> Oh yes, my fault.
>
> The "CONFIGURE_STYLE = modinst" deletes the modules from inc. It
> adds p5-Module-Install as build dependency automatically, but not
> the others.
>
> In general I think bundling other modules in inc does not fit well
> in our ports tree. We should use the package that is maintained
> and tested with OpenBSD and not something that is included somewhere.
> Also inc makes it harder to review module updates as you see a lot
> of unreleated stuff.
>
> That is why I prefer to place a "rm -rf -- ${WRKSRC}/inc" in the
> Makefile. But I should not forget to replace inc with dependencies.
>
> New version attached.
>
> bluhm
>

I have a modified perl.port.mk I've been using for some time, with
additional dependencies in the ports that need them including new ports
required as a result of removing everything under ${WRKSRC}/inc for all
modinst ports, there might have been some reason for not removing inc
itself just can't recall at this time...

$ cvs -R -q diff -uNp perl.port.mk



Index: perl.port.mk
===================================================================
RCS file: /home/cvs/ports/infrastructure/mk/perl.port.mk,v
retrieving revision 1.29
diff -u -p -r1.29 perl.port.mk
--- perl.port.mk 26 Apr 2016 10:56:59 -0000 1.29
+++ perl.port.mk 26 Apr 2016 13:20:04 -0000
@@ -66,7 +66,7 @@ MODPERL_configure = ${_MODPERL_preconfig
. if ${CONFIGURE_STYLE:L:Mmodinst}
BUILD_DEPENDS += devel/p5-Module-Install
CONFIGURE_ARGS += --skipdeps
-_MODPERL_preconfig = rm -rf ${WRKSRC}/inc/Module/*Install*
+_MODPERL_preconfig = rm -rf ${WRKSRC}/inc/*
. else
_MODPERL_preconfig = :
. endif
$