Re: NEW: devel/py-icecream

On 2023/11/02 09:46, Stuart Henderson wrote:
>
> (no need to include two copies of the diff plus a tar; normally we
> just use a tar for new ports though one inline copy can be useful for
> quoting)

Ack.

> This combination of variables doesn't go together. MODPY_SETUPUTILS and
> MODPY_PYBUILD are mutually exclusive (new ports should use MODPY_PYBUILD).

> There's a problem with two of icecream tests with pytest but I think it's
> best to just note that in a comment rather than try to force using the
> deprecated setup.py test runner - https://github.com/gruns/icecream/issues/134

Right. I noticed I was deviating from the most common porting practice
of just using pytest and I forgot to add a note explaining why I did that.

I think it is now fixed, I reverted that and now the port is using the following
options:


> MODPY_PI= Yes
> MODPY_PYBUILD= setuptools
>
> # Unfortunately, not all unit tests succeed when executed by pytest.
> # See https://github.com/gruns/icecream/issues/134 for more details.
> # XXX: Verify if this issue is also present with Python >= 3.11.
> # According to upstream, this is a 3.10 specific issue, but that's
> # pending verification in OpenBSD.
>
> MODPY_PYTEST= Yes
> SEPARATE_BUILD= Yes


I'll follow up on this once Python 3.11 or greater is available to confirm
if the unit test issue with pytest was specific to 3.10 or an upstream
fix is required.

> The rest looks good

I attached a new revision addressing the comments above.

Thanks,
Miguel.

--
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x6E608B637D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche