Thursday, March 26, 2026

Re: Patch to fix x11/worker sparc64 build

ok

On 2026/03/25 20:35, Kurt Mosiejczuk wrote:
> The build on sparc64 was failing with:
>
> argclass.cc: In member function 'std::pair<IntArg, bool> StringArg::convertToInt() const':
> argclass.cc:38:15: error: 'INT32_MIN' was not declared in this scope; did you mean 'INT_MIN'?
> 38 | l >= INT32_MIN && l <= INT32_MAX ) {
> | ^~~~~~~~~
> | INT_MIN
> argclass.cc:38:33: error: 'INT32_MAX' was not declared in this scope
> 38 | l >= INT32_MIN && l <= INT32_MAX ) {
> | ^~~~~~~~~
> argclass.cc:23:1: note: 'INT32_MAX' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'
> 22 | #include "argclass.hh"
> +++ |+#include <cstdint>
> 23 |
>
> So I took the advice of the compiler and added that include line.
> It _did_ fix the build on sparc64 :)
>
> It also doesn't break the build on amd64.
>
> ok?
>
> --Kurt
>
> Index: patches/patch-src_argclass_cc
> ===================================================================
> RCS file: patches/patch-src_argclass_cc
> diff -N patches/patch-src_argclass_cc
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-src_argclass_cc 26 Mar 2026 00:31:49 -0000
> @@ -0,0 +1,15 @@
> +'INT32_MAX' was not declared in this scope
> +
> +this is probably fixable by adding '#include <cstdint>'
> +
> +Index: src/argclass.cc
> +--- src/argclass.cc.orig
> ++++ src/argclass.cc
> +@@ -20,6 +20,7 @@
> + */
> +
> + #include "argclass.hh"
> ++#include <cstdint>
> +
> + ArgClass::~ArgClass()
> + {
>

No comments:

Post a Comment