Re: devel/pscan update

On 2017/04/15 10:38, Prof. Dr. Steffen Wendzel wrote:
> Dear all:
>
> I updated the pscan port (tgz available here:
> http://wendzel.de/dr.org/files/Projects/OpenBSD/ports/).
>
> Note: The version in the current ports tree is "1.6", the new version is
> "1.3". This is because the developer changed the version to 1.3. The old
> code was from 2000, the current code is from 2007. No substantial changes
> were made (I diff'ed all files between both versions).
>
> Summary of changes:
>
> - download URL did not exist anymore; fixed: new URL added
> - changed version to 1.3
> - adjusted parameters in Makefile to make compile of 1.3 feasible
> - added more example files which are now also installed to filesystem
> - replaced my old e-mail port's maintainer address with a newer one
>
> I did not ran OpenBSD for several years now and hope I did not forgot to
> cover any important aspect of the port creation process. I performed several
> tests, which indicated the error-free functioning of my new pscan port.
>
> Please feel free to use my update for the OpenBSD ports tree and perform any
> changes you like.

Thanks. Here's a modified version in the form of a diff to the ports tree.
Apart from a few ports housekeeping changes, I also updated the pkg/DESCR
file to give a better indication of what it does.

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/pscan/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- Makefile 11 Mar 2013 10:50:25 -0000 1.6
+++ Makefile 15 Apr 2017 10:38:44 -0000
@@ -2,24 +2,27 @@

COMMENT= limited problem scanner for C source files

-V= 1.6
+V= 1.3
+
+PKGNAME= pscan-$V
DISTNAME= pscan
-PKGNAME= ${DISTNAME}-${V}
-REVISION = 0
+DISTFILES= ${PKGNAME}{pscan}${EXTRACT_SUFX}
+EPOCH= 0
+WRKDIST= ${WRKDIR}
+
CATEGORIES= devel

-HOMEPAGE= http://www.striker.ottawa.on.ca/~aland/pscan/
+HOMEPAGE= http://deployingradius.com/pscan/

-MAINTAINER= Steffen Wendzel <cdp@doomed-reality.org>
+MAINTAINER= Steffen Wendzel <wendzel@hs-worms.de>

-# GPL
+# GPLv2+
PERMIT_PACKAGE_CDROM= Yes

MASTER_SITES= ${HOMEPAGE}

WANTLIB= c

-DIST_SUBDIR= ${DISTNAME}-${V}
ALL_TARGET= pscan

NO_TEST= Yes
@@ -29,5 +32,7 @@ do-install:
${INSTALL_SCRIPT} ${WRKSRC}/find_formats.sh ${PREFIX}/bin
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pscan
${INSTALL_DATA} ${WRKSRC}/test.c ${PREFIX}/share/examples/pscan
+ ${INSTALL_DATA} ${WRKSRC}/wu-ftpd.pscan ${PREFIX}/share/examples/pscan
+ ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/examples/pscan

.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/pscan/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 18 Jan 2015 03:13:40 -0000 1.3
+++ distinfo 15 Apr 2017 10:38:44 -0000
@@ -1,2 +1,2 @@
-SHA256 (pscan-1.6/pscan.tar.gz) = DzqfW5HdulNj13c0pxf1QSYLIVTJZLnOY1EbP/UCcu4=
-SIZE (pscan-1.6/pscan.tar.gz) = 14555
+SHA256 (pscan-1.3.tar.gz) = ABJPoJFQzv+u7SIv/umVmy3WmDNqIyVn/VNsRjRB9lk=
+SIZE (pscan-1.3.tar.gz) = 17332
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/devel/pscan/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 21 Sep 2006 20:52:26 -0000 1.1.1.1
+++ pkg/DESCR 15 Apr 2017 10:38:44 -0000
@@ -1,2 +1,2 @@
-PScan is a program which attempts to scan C source files for common
-function abuses, which often lead to buffer overflows.
+PScan is a program which attempts to scan C source files for problematic
+uses of printf style functions, which often lead to buffer overflows.
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/pscan/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -r1.2 PLIST
--- pkg/PLIST 6 Nov 2007 06:30:32 -0000 1.2
+++ pkg/PLIST 15 Apr 2017 10:38:44 -0000
@@ -4,3 +4,5 @@ bin/find_formats.sh
bin/pscan
share/examples/pscan/
share/examples/pscan/test.c
+share/examples/pscan/wu-ftpd.pscan
+share/examples/pscan/README