Re: new: net/bitlbee-facebook

> Bump REVISION. I would also set PKGSPEC so that ports depending on bitlbee
> are tied to the correct version of bitlbee, otherwise for future bitlbee
> updates we'd need to check for any ABI change in the plugin interface and
> bump bitlbee-facebook and any other deps. Like this:
>
> V= 3.5.1
> DISTNAME= bitlbee-$V
> PKGSPEC= bitlbee-=$V
> REVISION= 0

Fixed, attached below.

> I'd drop "The" and mention "messenger" too e.g.
>
> COMMENT= Facebook Messenger protocol plugin for bitlbee

This was copy-pasted from the projects homepage, but your version reads
better.

> Kill the useless static archive (probably "LIBTOOL_FLAGS= --tag=disable-static"),
> and probably also @comment the .la file (but check that it works without).

It works, fixed and attached.



Index: Makefile
===================================================================
RCS file: /cvs/ports/net/bitlbee/Makefile,v
retrieving revision 1.59
diff -u -p -r1.59 Makefile
--- Makefile 27 May 2017 08:01:33 -0000 1.59
+++ Makefile 27 May 2017 14:41:50 -0000
@@ -2,7 +2,10 @@

COMMENT= IRC proxy to connect to AIM, ICQ, Jabber and Yahoo

-DISTNAME= bitlbee-3.5.1
+V= 3.5.1
+DISTNAME= bitlbee-$V
+PKGSPEC= bitlbee-=$V
+REVISION= 0
CATEGORIES= net

HOMEPAGE= http://bitlbee.org/
@@ -40,7 +43,7 @@ CONFIGURE_ARGS+= --bindir=${PREFIX}/libe
USE_GMAKE= Yes
MAKE_ENV= "CC=${CC}" "CFLAGS=${CFLAGS}"
FAKE_FLAGS= ETCDIR=${EXAMPLEDIR}
-FAKE_TARGET= install install-etc
+FAKE_TARGET= install install-etc install-dev
SUBST_VARS= DB_DIR

FLAVORS = libpurple otr
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/net/bitlbee/pkg/PLIST,v
retrieving revision 1.16
diff -u -p -r1.16 PLIST
--- pkg/PLIST 9 Apr 2012 15:37:52 -0000 1.16
+++ pkg/PLIST 27 May 2017 14:41:50 -0000
@@ -3,6 +3,45 @@
@newgroup _bitlbee:509
@newuser _bitlbee:509:_bitlbee:daemon:Bitlbee Account:/nonexistent:/sbin/nologin
@extraunexec rm -rf ${DB_DIR}/*
+include/bitlbee/
+include/bitlbee/account.h
+include/bitlbee/arc.h
+include/bitlbee/auth.h
+include/bitlbee/base64.h
+include/bitlbee/bee.h
+include/bitlbee/bitlbee.h
+include/bitlbee/commands.h
+include/bitlbee/conf.h
+include/bitlbee/config.h
+include/bitlbee/dcc.h
+include/bitlbee/events.h
+include/bitlbee/ft.h
+include/bitlbee/ftutil.h
+include/bitlbee/help.h
+include/bitlbee/http_client.h
+include/bitlbee/ini.h
+include/bitlbee/ipc.h
+include/bitlbee/irc.h
+include/bitlbee/json.h
+include/bitlbee/json_util.h
+include/bitlbee/log.h
+include/bitlbee/md5.h
+include/bitlbee/misc.h
+include/bitlbee/nick.h
+include/bitlbee/nogaim.h
+include/bitlbee/oauth.h
+include/bitlbee/oauth2.h
+include/bitlbee/otr.h
+include/bitlbee/proxy.h
+include/bitlbee/query.h
+include/bitlbee/set.h
+include/bitlbee/sha1.h
+include/bitlbee/sock.h
+include/bitlbee/ssl_client.h
+include/bitlbee/storage.h
+include/bitlbee/url.h
+include/bitlbee/xmltree.h
+lib/pkgconfig/bitlbee.pc
@man man/man5/bitlbee.conf.5
@man man/man8/bitlbee.8
@bin sbin/bitlbee

--
Michal Mazurek