Re: Fix manual page section for devel/libmagic

On Thu, Jun 29, 2017 at 03:49:19AM +0200, Jeremie Courreges-Anglas wrote:
>Well spotted; I have committed a fix.
>
>Some problems with your submission:
>- consistency is good but no need to submit changes for minor whitespace
> issues. *Especially* for SHARED_LIBS and WANTLIB, which tend to be
> copy/pasted.
bcallah on #openbsd-daily also mentioned not to change whitespaces in
Makefiles; noted, thanks.
>- since the manpage isn't installed in section 4 any more, you need to
> update the PLIST with ''make plist''. Else ''make package'' will
> fail.
My fault, forgot to include/attach the PLIST diff as well.
>- since the change you propose changes the content of the package, you
> should bump REVISION (here, set it to 0).
Fair point.

Here's an updated diff that also fixes two typos in DESCR.


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libmagic/Makefile,v
retrieving revision 1.29
diff -u -p -r1.29 Makefile
--- Makefile 16 Jun 2016 15:35:02 -0000 1.29
+++ Makefile 29 Jun 2017 02:11:41 -0000
@@ -6,6 +6,7 @@ COMMENT= library to determine file type
V= 5.28
DISTNAME= file-${V}
PKGNAME= libmagic-${V}
+REVISION= 1

SHARED_LIBS += magic 4.2 # 1.0

@@ -20,6 +21,7 @@ WANTLIB += z

MASTER_SITES= ftp://ftp.astron.com/pub/file/

-CONFIGURE_STYLE= gnu
+CONFIGURE_STYLE=gnu
+CONFIGURE_ARGS= --enable-fsect-man5=yes

.include <bsd.port.mk>
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/devel/libmagic/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 14 Apr 2006 17:02:58 -0000 1.1.1.1
+++ pkg/DESCR 29 Jun 2017 02:11:42 -0000
@@ -1,4 +1,4 @@
-libmagic is a library to which attempts to classify files. There ar
+libmagic is a library which attempts to classify files. There are
three sets of tests, performed in the following order:

- filesystem tests
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/libmagic/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST 29 Sep 2013 23:29:24 -0000 1.5
+++ pkg/PLIST 29 Jun 2017 02:11:42 -0000
@@ -6,5 +6,5 @@ lib/libmagic.la
@lib lib/libmagic.so.${LIBmagic_VERSION}
@comment @man man/man1/file.1
@man man/man3/libmagic.3
-@man man/man4/magic.4
+@man man/man5/magic.5
share/misc/magic.mgc