Re: [NEW] net/google-compute-engine

On Thu, 1 Jun 2017 22:03:22 -0300, Helen Koike
<helen.koike@collabora.com> wrote:

> I would appreciate if someone could review it and make any comments
> or tell me that the package is OK.

1. $ portcheck
patches/patch-google__compute__engine_accounts_accounts__daemon.py does not have $OpenBSD$ RCS tag at the top
[...]

I guess you don't know about make update-patches' do you? :)

2. I'm a bit puzzled by the number of rcscripts.

3. I think you lack share/doc/pkg-readmes/${FULLPKGNAME} in the PLIST

4. HOMEPAGE is already set by the GH_* things so you can remove it

5. There are a bunch of bash script with
google_compute_engine_init/build_packages.sh:#!/bin/bash
which I guess should be changed

6. does it really need net/ntp as a dependency?
google_compute_engine/clock_skew/clock_skew_daemon.py: ntpd_inactive = subprocess.call(['/etc/rc.d/ntpd', 'check'])
That rather smells like openntpd should be enough :)

6bis. How did you choose the actual list of dependencies?

7. Any reason to not to enable tests?

8. patch-google__compute__engine_boto_boto__config.py is empty

9. What's the point of patching stuff like
- '/usr/bin/google_instance_setup.')
+ '%%PREFIX%%/bin/google_instance_setup.')
and then sed'ding it in pre-configure?

10. LOCALBASE wouldn't be better than PREFIX?

11. Don't you need a RDEP on net/py-netifaces?

There are probably other nits but that's all for now :)