Re: NEW: x11/wmutils

On Sat, Jul 29, 2017 at 05:16:24PM -0400, Brian Callahan wrote:
> Some notes:
> core/Makefile:
> * 1.4 is used twice, so make it into a V = 1.4 variable at the top of the
> Makefile
> * You already have CATEGORIES, MAINTAINER, and NO_TEST in the top-level
> Makefile, don't repeat them here.
> * You can get rid of the MAKE_ENV line and make the MAKE_FLAGS line:
> MAKE_FLAGS = CFLAGS="${CFLAGS} -I${X11BASE}/include" \
> LDFLAGS="-L${X11BASE}/lib -lxcb -lxcb-util"
> to achieve the same effect in fewer lines.
> * We prefer sed to perl in the post-patch line.
>
> opt/Makefile:
> * 1.0 is used twice, make it into V = 1.0 at the top of the Makefile
> * Remove CATEGORIES, MAINTAINER, and NO_TEST
> * Remove MAKE_ENV and change the MAKE_FLAGS line to be like core/Makefile
> above.
>
> ~Brian

Please find attached an updated version which addresses these
concerns.

Also, I moved all of the common variables into the toplevel makefile.

I saw this email first, so I used bcallah@'s suggestion of a V
variable instead of sthen@'s suggestion.

--
Kaashif Hymabaccus
GPG: 3E810B04