Re: NEW: security/fwknop

On Fri, Aug 25 2017, Ingo Feinerer <feinerer@logic.at> wrote:
> Hi,
>
> in the need of a client for "fwknop" (the "FireWall KNock OPerator") I
> packaged the official client (http://www.cipherdyne.org/fwknop/). As
> there is a server daemon in the sources as well, I included it too.
>
> $ cat pkg/DESCR
> fwknop stands for the "FireWall KNock OPerator", and implements an
> authorization scheme called Single Packet Authorization (SPA). This method of
> authorization is based around a default-drop packet filter and libpcap. SPA is
> essentially next generation port knocking.
>
> IMHO the port is in good condition; the only drawback is "USE_LIBTOOL = gnu".
> I was not able to get rid of it.
>
> OK to import?

Looks good at first, I did not try to investigate the libtool issue, but
this needs fixing first:

depbase=`echo md5.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; /usr/local/bin/libtool --tag=disable-static --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT md5.lo -MD -MP -MF $depbase.Tpo -c -o md5.lo /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/md5.c && mv -f $depbase.Tpo $depbase.Plo
libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIC -D_FORTIFY_SOURCE=2 -MT md5.lo -MD -MP -MF .deps/md5.Tpo -c /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/md5.c -fPIC -DPIC -o .libs/md5.o
/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/md5.c:50:6: warning: Undetermined or unsupported Byte Order... We will try LITTLE_ENDIAN [-W#warnings]
#warning Undetermined or unsupported Byte Order... We will try LITTLE_ENDIAN
^
1 warning generated.
depbase=`echo rijndael.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; /usr/local/bin/libtool --tag=disable-static --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT rijndael.lo -MD -MP -MF $depbase.Tpo -c -o rijndael.lo /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/rijndael.c && mv -f $depbase.Tpo $depbase.Plo
libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIC -D_FORTIFY_SOURCE=2 -MT rijndael.lo -MD -MP -MF .deps/rijndael.Tpo -c /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/rijndael.c -fPIC -DPIC -o .libs/rijndael.o
depbase=`echo sha1.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; /usr/local/bin/libtool --tag=disable-static --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT sha1.lo -MD -MP -MF $depbase.Tpo -c -o sha1.lo /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/sha1.c && mv -f $depbase.Tpo $depbase.Plo
libtool: compile: cc -DHAVE_CONFIG_H -I. -I/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib -I.. -I/usr/local/include -I /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/common -O2 -pipe -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIC -D_FORTIFY_SOURCE=2 -MT sha1.lo -MD -MP -MF .deps/sha1.Tpo -c /usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/sha1.c -fPIC -DPIC -o .libs/sha1.o
/usr/ports/pobj/fwknop-2.6.9/fwknop-2.6.9/lib/sha1.c:126:6: warning: Undetermined or unsupported Byte Order... We will try LITTLE_ENDIAN [-W#warnings]
#warning Undetermined or unsupported Byte Order... We will try LITTLE_ENDIAN
^
1 warning generated.

The (ugly) diff attached works around the problem.