Re: [UPDATE] editors/hexedit to 1.3

On Sat, Aug 19 2017, Frederic Cambus <fred@statdns.com> wrote:
> Hi ports@,
>
> Here is a diff to update hexedit to 1.3.
>
> Notable changes:
>
> - Switch to GitHub and update HOMEPAGE
> - Release tarball doesn't bundle a configure script, so the port now
> uses autoconf + automake
> - Update license marker to specify GPLv2+
> - Drop the now useless patch
> - Regenerate WANTLIB
>
> Comments? OK?

Looks good, except for...

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/editors/hexedit/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 11 Mar 2013 11:02:49 -0000 1.25
> +++ Makefile 19 Aug 2017 17:05:47 -0000
> @@ -2,23 +2,29 @@
>
> COMMENT= view and edit files in hexadecimal or ASCII
>
> -DISTNAME= hexedit-1.2.12
> -CATEGORIES= editors
> +GH_ACCOUNT= pixel
> +GH_PROJECT= hexedit
> +GH_TAGNAME= 1.3
>
> -MASTER_SITES= http://www.chez.com/prigaux/ \
> - http://merd.net/pixel/
> -EXTRACT_SUFX= .src.tgz
> +CATEGORIES= editors
>
> -HOMEPAGE= http://www.chez.com/prigaux/hexedit.html
> +HOMEPAGE= http://rigaux.org/hexedit.html
>
> -# GPL
> +# GPLv2+
> PERMIT_PACKAGE_CDROM= Yes
>
> -WANTLIB= c curses
> +WANTLIB= c ncurses
> +
> +BUILD_DEPENDS = ${MODGNU_AUTOCONF_DEPENDS} \
> + ${MODGNU_AUTOMAKE_DEPENDS}
> +
> +CONFIGURE_STYLE= autoconf
> +AUTOCONF_VERSION= 2.69
> +AUTOMAKE_VERSION= 1.15

automake isn't used. You can just kill AUTOMAKE_VERSION and
BUILD_DEPENDS (CONFIGURE_STYLE=autoconf + AUTOCONF_VERSION will do the
right thing).

>
> -CONFIGURE_STYLE= gnu dest
> NO_TEST= Yes
>
> -WRKDIST= ${WRKDIR}/hexedit
> +post-build:
> + m4 -DVERSION=${GH_TAGNAME} ${WRKSRC}/hexedit.1.in > ${WRKSRC}/hexedit.1
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/editors/hexedit/distinfo,v
> retrieving revision 1.5
> diff -u -p -r1.5 distinfo
> --- distinfo 17 Sep 2012 12:50:09 -0000 1.5
> +++ distinfo 19 Aug 2017 17:05:47 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (hexedit-1.2.12.src.tgz) = vP+/PRKFFsxOHaZEhYZvu19idU8q+DJ+elJ4VRhroQ8=
> -SIZE (hexedit-1.2.12.src.tgz) = 65802
> +SHA256 (hexedit-1.3.tar.gz) = iNSJ37iV4ouyRyYTc2/GoUcDT01LA487nReOaWm//XA=
> +SIZE (hexedit-1.3.tar.gz) = 29620
> Index: patches/patch-hexedit_h
> ===================================================================
> RCS file: patches/patch-hexedit_h
> diff -N patches/patch-hexedit_h
> --- patches/patch-hexedit_h 17 Sep 2012 12:50:09 -0000 1.2
> +++ /dev/null 1 Jan 1970 00:00:00 -0000
> @@ -1,11 +0,0 @@
> -$OpenBSD: patch-hexedit_h,v 1.2 2012/09/17 12:50:09 gonzalo Exp $
> ---- hexedit.h.orig Tue Nov 8 13:16:47 2005
> -+++ hexedit.h Mon Sep 3 13:56:59 2012
> -@@ -5,6 +5,7 @@
> - #include <stdio.h>
> - #include <stdlib.h>
> - #include <string.h>
> -+#include <sys/param.h>
> - #include <sys/types.h>
> - #include <sys/stat.h>
> - #if HAVE_FCNTL_H
>

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE