devel/ectags broken

Hi,

similar to devel/universal-ctags, the parent project devel/ectags
is broken for the same reasons, also analyzed by guenther@.
Also, lots of people keep reporting it to me in private, so i'm
posting here.

Here is a minimal patch letting it build again; not tested at
run-time. Note that this is a band-aid; a proper fix would require
changing all instances of __unused__ and __printf__ in all *.c files
to something like "ectags_unused", or even better just rely on the
standard __attribute__ names throughout and not define anything in
the first place. But i'm not sure whether upstream still exists.

Should this be committed?

This overrides my previous patch sent to the MAINTAINER in private,
incorporating stylistic feedback from naddy@.

Yours,
Ingo


Index: patches/patch-eiffel_c
===================================================================
RCS file: patches/patch-eiffel_c
diff -N patches/patch-eiffel_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-eiffel_c 6 Sep 2017 11:23:43 -0000
@@ -0,0 +1,16 @@
+$OpenBSD$
+
+stop stomping on implementation namespace
+
+Index: eiffel.c
+--- eiffel.c.orig
++++ eiffel.c
+@@ -34,6 +34,8 @@
+ #include "read.h"
+