Thursday, September 28, 2017

Re: arm64 build fix for net/gtk-gnutella

On Thu, Sep 28 2017, Peter Hessler <phessler@openbsd.org> wrote:
> #error "This architecture may be unsupported. float must use IEEE 754."
>
> It's a trivial fix, as you can see.
>
> endian.h is not installed, so a package bump shouldn't be necessary.
>
> OK?

Looks harmless for other archs, ok.

Another approach would be to just assume IEEE754 (then we don't need to
check whether the list is complete). After all, we don't handle vax any
more.

> Index: net/gtk-gnutella/patches/patch-src_lib_endian_h
> ===================================================================
> RCS file: net/gtk-gnutella/patches/patch-src_lib_endian_h
> diff -N net/gtk-gnutella/patches/patch-src_lib_endian_h
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ net/gtk-gnutella/patches/patch-src_lib_endian_h 28 Sep 2017 09:08:05 -0000
> @@ -0,0 +1,13 @@
> +$OpenBSD$
> +
> +Index: src/lib/endian.h
> +--- src/lib/endian.h.orig
> ++++ src/lib/endian.h
> +@@ -246,6 +246,7 @@ poke_le64(gpointer p, guint64 v)
> + #if \
> + defined(__alpha__) || \
> + defined(__arm__) || \
> ++ defined(__aarch64__) || \
> + defined(__hppa__) || \
> + defined(__i386__) || \
> + defined(__ia64__) || \

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

No comments:

Post a Comment