On Tue Sep 12, 2017 at 05:18:14PM +0000, Stuart Henderson wrote:
> On 2017/09/12 17:05, Jeremie Courreges-Anglas wrote:
> >
> > On Tue, Sep 12 2017, Giovanni Bechis <giovanni@paclan.it> wrote:
> > > On Mon, Sep 11, 2017 at 09:42:35PM +0200, Rafael Sadowski wrote:
> > >> Hi All,
> > >>
> > >> please find below a simple update diff for ninja.
> > >>
> > >> - add write_fake_manifests.py and measure.py to PLIST.
> > >> - add NO_TEST otherwise there is an error if run regress.
> > > added a do-test target to fix regression tests.
Great Giovanni!
>
> I'd be ok with adding those to the current port.
Yes please!
>
> > Hah, nice.
> >
> > > Cheers
> > > Giovanni
> > >
> > >> Tested with devel/kf5, graphics/opencv, graphics/krita on AMD64.
> > >>
> > >> Would like someone run a bulk with the diff below?
> > >>
> > >> Comments? Ok?
> >
> > Maybe obvious: we are approaching release and ninja is kinda critical,
> > so better watch out for regressions.
>
> Yep, so let's have an evaluation. What's in the update? Does it bring
> anything that is important to us that means we should have it before
> release? (I don't know about timescales but it's obviously getting
> close.)
Good question
https://github.com/ninja-build/ninja/compare/717b7b4a31db6027207588c0fb89c3ead384747b...master
I don't see anything that is very important to us (before release).
> If not then I'd be happier waiting than doing an update of
> something like this which does really need bulk build testing.
I agree with you. I'm not in hurry with this update.
No comments:
Post a Comment