On 2017/09/24 16:42, Jérôme KASPER wrote:
> Hi ports, Denton,
>
> please find attached an update to DevIL 1.8.0
>
> Changes :
> -Github rebasement
> -Build system changed from autotools to cmake
> -updated WANTLIB from SDL > SDL2 and lcms >lcms2
> -removed openjpeg as LIB_DEPENDS
>
cvs diffs for updates please, not new tarballs.
: # $OpenBSD: Makefile,v 1.24 2017/09/24 17:53:23 jkasper Exp $
- leave this line alone
: DISTNAME= ${GH_PROJECT}-1.8.0
- this is the default, leave it out
: WRKDIST= ${WRKDIR}/${DISTNAME}/DevIL
- WRKDIST is set automatically for GH_* ports.
the thing you are trying to set here is actually WRKSRC, not WRKDIST.
it should be "WRKSRC=${WRKDIST}/DevIL" instead.
: SHARED_LIBS+= IL 2.0
: SHARED_LIBS+= ILU 2.0
: SHARED_LIBS+= ILUT 2.0
SHARED_LIBS goes towards the top of the Makefile. see the ordering
in ports/infrastructure/templates/Makefile.template.
: #include doc for later post-install
: post-extract:
: cp ${WRKDIR}/${DISTNAME}/DevIL-docs/*.pdf ${WRKDIST}/docs/
: cp ${WRKDIR}/${DISTNAME}/DevIL-docs/*.doc ${WRKDIST}/docs/
:
: post-install:
: mkdir ${PREFIX}/share/devil/
: cd ${WRKSRC}; tar cf - examples docs | tar xf - -C \
: ${PREFIX}/share/devil/
- copying the docs to one directory, then to another later, makes
no sense. it would be more sensible to just copy them once in the
post-install. but also by copying like this, you install some
useless junk (makefile, doxyfile, scripts..)
I would suggest getting rid of both the docs and the examples
though. They're not useful to most people who would install the package.
> OK ? Comments ?
as you're not a committer, there's not a lot of point asking for an OK ;)
we're heading towards release right now. this sort of update would be
more appropriate for after we move to 6.3-current.
No comments:
Post a Comment