Re: [update] i3-4.14

On Mon, Sep 04, 2017 at 08:11:10AM -0400, Josh Grosse wrote:
> On Mon, Sep 04, 2017 at 09:18:18AM +0000, David Coppa wrote:
> >
> > Now that 4.14 is out, here's the diff to update our port.
> >
> > Comments / OKs ?

ok.

I've been running with the release candidate for a while now and this
version builds and works fine.

> Builes and works fine here on amd64. But I happened to issue a make test, and it fails with:
>
> testcases/test_inject_randr15-inject_randr1.5.o: In function `child_cb':
> /usr/ports/pobj/i3-4.14/i3-4.14/../i3-4.14/testcases/inject_randr1.5.c:(.text+0x4a4): undefined reference to `WIFEXITED'
> /usr/ports/pobj/i3-4.14/i3-4.14/../i3-4.14/testcases/inject_randr1.5.c:(.text+0x4b2): undefined reference to `WTERMSIG'
> /usr/ports/pobj/i3-4.14/i3-4.14/../i3-4.14/testcases/inject_randr1.5.c:(.text+0x4c3): undefined reference to `WEXITSTATUS'
> cc: error: linker command failed with exit code 1 (use -v to see invocation)
> gmake[1]: *** [Makefile:1612: test.inject_randr15] Error 1
>

This build failure is due to a missing include in inject_randr1.5.c
(see wait(2)).

Not sure if it's worth upstreaming this, as the test suite will fail a
bit later anyway:

Index: patches/patch-testcases_inject_randr1_5_c
===================================================================
RCS file: patches/patch-testcases_inject_randr1_5_c
diff -N patches/patch-testcases_inject_randr1_5_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-testcases_inject_randr1_5_c 4 Sep 2017 13:42:53 -0000
@@ -0,0 +1,13 @@
+$OpenBSD$
+
+Index: testcases/inject_randr1.5.c
+--- testcases/inject_randr1.5.c.orig
++++ testcases/inject_randr1.5.c
+@@ -23,6 +23,7 @@
+ #include <sys/resource.h>
+ #include <sys/mman.h>
+ #include <sys/stat.h>
++#include <sys/wait.h>
+ #include <libgen.h>
+
+ static void uds_connection_cb(EV_P_ ev_io *w, int revents);