Re: NEW: devel/clazy

On Sat Dec 30, 2017 at 06:47:46PM -0500, Brian Callahan wrote:
> Hi Rafael --
>
> On 12/30/17 11:59, Rafael Sadowski wrote:
> > Okay, before the year ends, here is a new port.
> >
> > $ pkg/DESCR
> > ---
> > cazy is a compiler plugin which allows clang to understand Qt semantics.
> > You get more than 50 Qt related compiler warnings, ranging from unneeded memory
> > allocations to misusage of API, including fix-its for automatic refactoring.
> > ---
> >
> > More infos: https://github.com/KDE/clazy
> >
> > Works fine here on amd64. Ok to import?
> >
> > Best regards and a healthy start into the New Year.
> >
> > Rafael Sadowski
>
> Some thoughts:
> * license is LGPLv2+ if I'm reading it right
> * typo in pkg/DESCR? cazy => clazy
> * Needs NO_TEST=Yes

fixed

> * should lib/libClangLazy.so be added to SHARED_LIBS?

There is only the EXPORT tag for clazylib in CMakeLists.txt, that's why
I don't think so.

> * I don't know about your COMPILER line. Why does clazy have to be compiled
> with ports-clang? I can imagine that causing problems on archs where
> devel/llvm is built with g++-4.9.4. I built clazy with base-clang, for
> example, and it was fine. It's definitely C++11, so maybe something like
> COMPILER=base-clang ports-gcc is in order?
> * WANTLIB is missing ${COMPILER_LIBCXX}

My mistake, build fine with base-clang. COMPILER_LIBCXX also fixed. New
tarball attached. Thanks Brian