Re: NEW libb2

On 12/31/17 13:37, Björn Ketelaars wrote:
> On Sun 31/12/2017 19:26, Klemens Nanni wrote:
>> On Sun, Dec 31, 2017 at 01:15:29PM -0500, Brian Callahan wrote:
>>> On 12/31/17 12:15, Björn Ketelaars wrote:
>>>> Enclosed with this mail a tarball for libb2 a C library providing BLAKE2b,
>>>> BLAKE2s, BLAKE2bp, and BLAKE2sp. BLAKE2 is a cryptographic hash function
>>>> faster than MD5, SHA-1, SHA-2, and SHA-3, yet is at least as secure as the
>>>> latest standard SHA-3.
>>>>
>>>> Borgbackup currently uses a bundled version of libb2. I would like to replace
>>>> use of this bundled version by this port.
>>>>
>>>> Comments/OKs?
>>>>
>>> Attached is an updated tarball.
>>> Changes/Fixes:
>>> * Use ${SETENV} in the pre-configure routine.
>>> * Improve pkg/DESCR
>>> * Remove a hardcoded -O3
>>> * Set CONFIGURE_ARGS so that things like -march=native don't happen
>>> * The library identifies itself as libb2-0.98, so rename package to
>>> libb2-0.98.20171225 to avoid future EPOCH bumps.
>> I was about to send a similar diff. What I'm still missing:
>>
>> SEPARATE_BUILD=Yes can be set.
>>
>> In pre-configure, use ./autogen.sh (containing `autoreconf -fvi') to
>> avoid adjusting the target in case the required steps in autogen.sh
>> change.
> Thanks for the fixes! Included a new tarball - based on Brian's work and
> Klemens's hints.

I'm ok with this version, with the unneeded SEPARATE_BUILD=Yes line removed.

~Brian