Friday, January 26, 2018

Re: cmake.port.mk and DEBUG

On Fri, Jan 26, 2018 at 12:22:56PM +0100, Jeremie Courreges-Anglas wrote:
> On Sun, Jan 21 2018, Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
> > On Sun, Jan 21 2018, Landry Breuil <landry@openbsd.org> wrote:
> >> On Sun, Jan 21, 2018 at 06:00:24PM +0100, Jeremie Courreges-Anglas wrote:
> >>> On Sat, Jan 20 2018, Stuart Henderson <stu@spacehopper.org> wrote:
> >>>
> >>> [...]
> >>>
> >>> > How about making the cmake debug-build stuff dependent on a
> >>> > flavour (like "CMAKE_DEBUG") rather than making DEBUG do
> >>> > double-duty as a compiler flag option *and* a cmake knob?
> >>> >
> >>> > (We already removed some other cases where DEBUG turned on
> >>> > port-specific debug options..)
> >>>
> >>> Looks like several people agree with this direction, so here's a diff
> >>> that adds MODCMAKE_DEBUG.
> >>>
> >>> Comments/oks?
> >
> > [...]
> >
> >> missing verb ? And i think, since ppl wont understand what it means....
> >
> > Yep, sorry. Do you suggest deleting the whole sentence?
>
> ping.

I feel uncomfortable with it, but okay :)

No comments:

Post a Comment