Re: UPDATE: sysutils/pick

On 01/01/18 11:21, Brian Callahan wrote:
>
> On 01/01/18 11:08, Anton Lindqvist wrote:
>> Hi,
>> Update pick to 2.0.1 from maintainer, the changelog can be found here[1]
>> and the only change is:
>>
>> - Typing a query fast could yield incorrect results.
>>
>> Comments? OK?
>>
>> [1] https://github.com/calleerlandsson/pick/releases/tag/v2.0.1
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/sysutils/pick/Makefile,v
>> retrieving revision 1.7
>> diff -u -p -r1.7 Makefile
>> --- Makefile    7 Nov 2017 14:16:54 -0000    1.7
>> +++ Makefile    1 Jan 2018 16:07:36 -0000
>> @@ -2,7 +2,7 @@
>>     COMMENT =    fuzzy select anything
>>   -V =        2.0.0
>> +V =        2.0.1
>>   DISTNAME =    pick-${V}
>>     CATEGORIES =    sysutils
>> Index: distinfo
>> ===================================================================
>> RCS file: /cvs/ports/sysutils/pick/distinfo,v
>> retrieving revision 1.6
>> diff -u -p -r1.6 distinfo
>> --- distinfo    7 Nov 2017 14:16:54 -0000    1.6
>> +++ distinfo    1 Jan 2018 16:07:36 -0000
>> @@ -1,2 +1,2 @@
>> -SHA256 (pick-2.0.0.tar.gz) =
>> DocUG5zKfDHU13yHp8BYLjFvQPkHZETHxuh6eR8a6As=
>> -SIZE (pick-2.0.0.tar.gz) = 107860
>> +SHA256 (pick-2.0.1.tar.gz) =
>> Sllrj0CjFrxOLA2OiEKBDXp7adRkpBDk7ipldOAWKeM=
>> +SIZE (pick-2.0.1.tar.gz) = 108010
>>
>
> Two thoughts:
> 1. SEPARATE_BUILD=Yes can be set
> 2. There's a -Werror floating around the build
>
> If you don't want to patch ${WRKSRC}/Makefile.in to remove the
> -Werror, this will do:
> pre-configure:
>         sed -i 's,-Werror,,g' ${WRKSRC}/Makefile.in
>
> ~Brian
>

I should also add that all the tests pass here on amd64 and armv7, so
I'm generally happy with the update.