On Tue, Feb 27, 2018 at 10:36:51PM +0000, Stuart Henderson wrote:
> On 2018/02/27 10:16, Thomas Frohwein wrote:
> > This diff switches fs2open to the release tarball. Simplifies things a ton
> > because now it doesn't need to fetch the git submodules separately. Includes
> > REVISION bump and new HOMEPAGE line.
> >
> > Builds and runs as before on a quick test run.
>
> This is a big improvement imho. Only problem is that the distfile name
> is unchanged which isn't handled very well in bulk builds at the moment
> (distfiles are shared between multiple arches, which are building from
> different versions of the tree - we could easily have 2 or 3 fast-arch
> builds, then a slow arch tries to build it and wants the old version,
> then fast arches build again, then another slow one, etc).
>
> Obviously this is not just going to affect fs2open but some other ports
> which are moved to /releases too, so let's pick a standard method to
> handle it before proceeding.
>
> > +DISTFILES = ${DISTNAME}${EXTRACT_SUFX}
>
> This line is the default so could normally be removed. But due to the
> distfile issue above I would propose this instead for now, and remove at
> next update:
>
> DISTFILES = ${DISTNAME}_1{${DISTNAME}}${EXTRACT_SUFX}
>
> And with this the distinfo would change to:
>
> SHA256 (fs2_open_3_8_0-source-Unix_1.tar.gz) = 0m/4tma9rh6fQquvL0mNs2EJPyKJ2nhVXx9vu6dWIic=
> SIZE (fs2_open_3_8_0-source-Unix_1.tar.gz) = 9040907
>
> Does that make sense?
That makes sense to me, maybe with a comment saying 'remove at next
update' ? :)
Landry
No comments:
Post a Comment