Re: [NEW] net/onionshare

Klemens Nanni wrote:
> On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
> > Klemens Nanni <kl3@posteo.org> wrote:
> > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
> > > beneath COMMENT; see infrastructure/templates/Makefile.template.
> > >
> > > RUN_DEPENDS lacks net/tor.
> > > onionshare-gui still starts but python will dump core when
> > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
> > > "Tor that is bundled with OpenShare" which is misleading.
> > >
> > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
> >
> > Attached is an updated port that addresses all of these comments.
> > Thanks a lot for the feedback!
> Looks good to me except for the bundle bits. Optimally this should be
> clarified upstream.

There has been a new release in the interim and my patches for the old
release were discussed a bit on GH. Attached is a new attempt that is
for the latest release (1.2) and that takes into account some of the
suggestions from other contributors.

I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
have not had time to investigate, thus NO_TEST=Yes. I'd like this to
be critiqued regardless, I don't see this as fatal to getting in if it
passes muster otherwise...

Feedback welcome.

Pax, -A
--
https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net}
pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D 09C1 4068 D5D5 62A7 29CF