Re: [Patch] games/urbanterror doesn't rely on W|X

On Fri, Feb 02, 2018 at 06:41:26AM +0200, mazocomp wrote:
> Hi!
>
> By quickly grepping Urban Terror's code I've seen:
>
> ./code/qcommon/vm_x86.c: if(mprotect(vm->codeBase, compiledOfs,
> PROT_READ|PROT_EXEC))
> ./code/qcommon/vm_x86_64.c: mem = mmap(NULL, stb.st_size,
> PROT_READ|PROT_EXEC, MAP_SHARED, fd, 0);
> ./code/qcommon/vm_x86_64.c: if(mprotect(vm->codeBase, compiledOfs,
> PROT_READ|PROT_EXEC))
>
> After that I removed USE_WXNEEDED from port's Makefile and tested this
> game (my /usr/local is not mounted under wxallowed). I enjoyed playing
> this game, no W^X violations noticed.

Thank you very much for this! I will give it a go, there is a small
hotfix update that needs to be done from upstream as well.

Unfortunately I am smack dab in the middle of a move, so I can't
jump on this just yet.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/urbanterror/Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile
> --- Makefile 8 Feb 2017 12:55:18 -0000 1.4
> +++ Makefile 2 Feb 2018 04:26:18 -0000
> @@ -1,6 +1,5 @@
> # $OpenBSD: Makefile,v 1.4 2017/02/08 12:55:18 sthen Exp $
>
> -USE_WXNEEDED = Yes
> ONLY_FOR_ARCHS = amd64 i386
>
> COMMENT = fast-paced hollywood-tactical shooter: "fun over realism"