Re: [NEW] net/onionshare

attila <attila@stalphonsos.com> writes:

>> attila wrote:
>> > Klemens Nanni wrote:
>> > > On Tue, Dec 12, 2017 at 10:45:21AM -0600, attila wrote:
>> > > > Klemens Nanni <kl3@posteo.org> wrote:
>> > > > > You should zap V and PKGNAME, set GH_TAGNAME=v1.1 and move GH_* right
>> > > > > beneath COMMENT; see infrastructure/templates/Makefile.template.
>> > > > >
>> > > > > RUN_DEPENDS lacks net/tor.
>> > > > > onionshare-gui still starts but python will dump core when
>> > > > > /usr/local/bin/tor is missing. It also mentions our net/tor package as
>> > > > > "Tor that is bundled with OpenShare" which is misleading.
>> > > > >
>> > > > > TEST_DEPENDS lacks net/py-stem and www/py-frozen-flask.
>> > > >
>> > > > Attached is an updated port that addresses all of these comments.
>> > > > Thanks a lot for the feedback!
>> > > Looks good to me except for the bundle bits. Optimally this should be
>> > > clarified upstream.
>> >
>> > There has been a new release in the interim and my patches for the old
>> > release were discussed a bit on GH. Attached is a new attempt that is
>> > for the latest release (1.2) and that takes into account some of the
>> > suggestions from other contributors.
>>
>> After I sent this I modified my patches slightly to accomodate another
>> suggestion by upstream and the pull request has now been merged, so
>> all these patches can go in the next update:
>> https://github.com/micahflee/onionshare/pull/585
>>
>> This is also in FreeBSD ports now (thanks to fellow torbsd.org member
>> Egypcio):
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225539
>>
>> > I changed TEST_DEPENDS for 1.2 but the tests fail now for me and I
>> > have not had time to investigate, thus NO_TEST=Yes. I'd like this to
>> > be critiqued regardless, I don't see this as fatal to getting in if it
>> > passes muster otherwise...
>>
>> Still have not had time to suss this out.
>>
>> Updated port attached with the actual patches that got upstream.
>
> Ping.

Hello,

I tried your port but the "-gui" SUBPACKAGE didn't work. "make plist"
includes the wrong stuff in for both SUBPACKAGE. -main had
onionshare-gui/*.py stuff and -gui didn't have onionshare/*.py.

Here is a port of the v1.3 with SUBPACKAGE -main and -gui. The v1.3
includes your patches merged by upstream.

One caveat (that I know of, there is probably more :p): I hardcoded the
name of the package in PLIST-main and PLIST-gui and used only the
version to locate the .egg-info file.

lib/python${MODPY_VERSION}/site-packages/onionshare-${V}-py${MODPY_VERSION}.egg-info
^^^^^^^^^^^^^^^^^

If there is a better way to handle this, I'd by happy to fix it.

WDYT?

Best,