Re: UPDATE archivers/zstd

On Fri, Mar 30, 2018 at 06:22:47PM +0100, Stuart Henderson wrote:
> On 2018/03/30 19:01, Björn Ketelaars wrote:
> > On Fri 30/03/2018 13:45, Klemens Nanni wrote:
> > > On Fri, Mar 30, 2018 at 05:30:55AM +0200, Björn Ketelaars wrote:
> > > > zstd received an update, which focuses on performance. Changelog can be
> > > > found at https://github.com/facebook/zstd/blob/dev/NEWS. The major
> > > > number of the shared lib has been bumped as a couple of symbols have
> > > > been removed, and new ones have been added.
> > > >
> > > > I've been running with this update for a couple of days on AMD64 using
> > > > its only customer: borgbackup.
> > > >
> > > > OK?
> > > Has anyone contacted upstream already to merge the trivial
> > > detection/support bits we're carrying in our patches? Would be nice to
> > > get those in, effectively limiting required patches on our site to
> > > library version handling.
> > >
> > > Tests fail with a bunch of "use of undeclared identifier", did they pass
> > > before?
> > >
> > > fatal error: too many errors emitted, stopping now [-ferror-limit=]
> > > 2 warnings and 20 errors generated.
> > > 2 warnings and 20 errors generated.
> >
> >
> > I'm having a deja vu [0] ;-)
> >
> > Could you send me your test.log?
> >
> > [0] https://marc.info/?l=openbsd-ports&m=151473111522358&w=2
> >
>
> I don't see that here. kn, do you have anything funny in CFLAGS/CDIAGFLAGS/etc?
No, happens with an empty/missing mk.conf(5).

Pruned archivers/zstd, fetched from cvs.openbsd.org, applied the patch,
ran make build... still getting errors. See attched `make build' log.

Running "(GENERIC.MP) #92: Wed Mar 21 15:23:36 MDT 2018" with
zstd-1.3.3p0 xz-5.2.3p0 lz4-1.8.1.2 installed.

> I have a different problem with tests though:
>
> - Compress without dictID
> tmp : 21.56% ( 42430 => 9148 bytes, tmp.zst)
> tmp.zst : Decoding error (36) : Restored data doesn't match checksum
> gmake[1]: *** [Makefile:307: zstd-playTests] Error 1
> gmake[1]: Leaving directory '/usr/obj/ports/zstd-1.3.4/zstd-1.3.4/tests'