Re: freerdp2 / remmina updates, vinagre fix

On 04/27/18 23:10, Denis Fondras wrote:
> It connects but I have some graphical glitches with freerdp2 which do not appear
> with 1.2. I haven't checked further.
>
/gdi:sw /bpp:15 parameters fixes the issue, at least /bpp:15 should be the default in remmina as far as I know.
https://github.com/FreeRDP/FreeRDP/issues/4111
Cheers
Giovanni

> On Fri, Apr 27, 2018 at 06:11:13PM +0200, Landry Breuil wrote:
>> On Fri, Apr 27, 2018 at 03:13:26PM +0200, Giovanni Bechis wrote:
>>> On Fri, Apr 27, 2018 at 02:53:54PM +0200, Landry Breuil wrote:
>>>> On Fri, Apr 27, 2018 at 12:48:32PM +0200, Giovanni Bechis wrote:
>>>>> On 04/27/18 12:24, Landry Breuil wrote:
>>>>>> Hi,
>>>>>>
>>>>>> so here's another attempt at upgrading freerdp, based on semarie@'s work
>>>>>> in https://marc.info/?l=openbsd-ports&m=151591792008660&w=2.
>>>>>>
>>>>>> Updated for freerdp 2.0.0rc2 and remmina 1.2.0rc29, patches to fix
>>>>>> vinagre coming from https://bugzilla.gnome.org/show_bug.cgi?id=765444
>>>>>> and https://bugzilla.gnome.org/show_bug.cgi?id=774473 being used by
>>>>>> various linux distros. remotebox and krdc are just spawning xfreerdp and
>>>>>> have support for freerdp 1.1+-style arguments so should just be fine
>>>>>> too.
>>>>>>
>>>>>> Runtime tests welcome, as from the hackroom i have no access to vnc or
>>>>>> rdp stuff.
>>>>>>
>>>>>> Landry
>>>>>>
>>>>> rdp fails while 2.0.0rc1 worked,
>>>>> ---------------------------------------------------------------------------------------------------------
>>>>> [12:45:59:596] [42437:d5083240] [ERROR][com.winpr.synch.timer] - InitializeWaitableTimer: os specific implementation is missing
>>>>> ---------------------------------------------------------------------------------------------------------
>>>>> winpr/libwinpr/synch/timer.c needs some love.
>>>>
>>>> I looked at the code, and besides
>>>> https://github.com/FreeRDP/FreeRDP/commit/9bd13c25c96610b847c43333513cae5e2476f447
>>>> i dont see how its that much different/more required than with rc1, are
>>>> you sure this message wasnt printed with rc1 ?
>>>>
>>> I double checked and, unfortunately on rc1 it works.
>>
>> Okay, so maybe we'll only update to rc1 then, until someone figures out
>> what this timer_create() stuff from posix is supposed to do and how we
>> can implement something equivalent with the apis we have.
>>
>> Here's the diff for rc1 which should be more or less equivalent to what
>> semarie@ sent in january.
>>
>> Landry
>