Re: UPDATE dnsdist

On 2 Apr 2018, at 19:09, Jeremie Courreges-Anglas wrote:

> On Mon, Apr 02 2018, "Peter van Dijk" <peter.van.dijk@powerdns.com>
> wrote:
>> On 2 Apr 2018, at 15:00, Peter van Dijk wrote:
> Fine, but I'd keep "--supervised" (and "-u _dnsdist") in daemon
> instead,
> else the script could hang the boot process if the user overrides
> daemon_flags but forgets --supervised. I think "-u _dnsdist" is
> desirable by default too, users can override it in daemon_flags if
> needed.

Ah yes, thanks for the pointer. I split them up while fighting an issue
with pgrep/pexp I can no longer reproduce.

>>> The dnsdist-lua.cc patch has been upstreamed as
>>> https://github.com/PowerDNS/pdns/pull/6429 for inclusion in the next
>>> dnsdist release.
>
> If this is what I think it is, this should be fixed in OpenBSD; it has
> bitten me with other ports, eg net/samba.

I agree. This is the second time I've upstreamed this workaround to
dnsdist - the first one got lost in a refactor.

>>> There is one open problem (that was present in the 1.2.0 port as
>>> well): installation delivers an empty dir /etc/dnsdist/dnsdist,
>>> instead of copying share/examples/dnsdist/dnsdistconf.lua to
>>> /etc/dnsdist/dnsdist.conf. I have tried various edits to pkg/PLIST
>>> to
>>> resolve this, but without success. The patch below leaves pkg/PLIST
>>> untouched until I (or someone else) figures out what to do here.
>
> Here's an updated patch that should address the bogus
> /etc/dnsdist/dnsdist directory and properly install the config file
> using @sample (pkg_delete -c will DTRT).

This works. I tried various variants over the last few days but
apparently I managed to miss the exact right one.

> One funny crash that happens in interactive mode, while resizing the
> terminal (probably not a blocking problem):
>
> > terminating with uncaught exception of type std::runtime_error:
> Error reading from TCP acceptor pipe (21) in blocking mode: failed in
> readn2: Interrupted system call
> Abort trap

Oh, interesting. Doesn't happen on macOS where I do most development.
Not a blocker in my opinion but I will investigate this one.

> I only looked at the items I mentioned, I'm not a dnsdist user.

It is appreciated!

Your patch looks good to me.

ok?

Kind regards,
--
Peter van Dijk
PowerDNS.COM BV - https://www.powerdns.com/