Re: New port - lv2 (LADSPA V2)

On 2018/05/30 08:03, Ken M wrote:
> It is the lv2 port I sent previously. I can send it again or just send the
> makefile if that makes it easier for posting this question.

Ah - found it. Easier to include in the same mail especially if you are
prodding for a response.

: DISTNAME = lv2-1.14.0
: PKGNAME = lv2-1.14.0
...
: DISTFILES = lv2-1.14.0.tar.xz
: EXTRACT_SUFX = .tar.xz

Lots of duplication, this should just be

DISTNAME = lv2-1.14.0
EXTRACT_SUFX = .tar.xz

: BUILD_DEPENDS = lang/gcc/4.9

What does this need gcc for?

It shouldn't be used on clang arches without an *exceptional* reason
(and in those very few cases it should use e.g. "COMPILER=ports-gcc" and
"${CC}" instead of hardcoding). Current exceptions are asterisk (needs
either codeblocks or gcc's nested functions; codeblocks doesn't work yet)
and "vmm-firwmare"/seabios and I think that's it.

: do-configure:
: cd ${WRKSRC} && PYTHON=${MODPY_BIN} ${MODPY_BIN} && CC=${PREFIX}/bin/egcc \
: ./waf configure --prefix=${PREFIX} \
: --mandir=${PREFIX}/man

splitting this line into pieces the second command doesn't make sense,

cd ${WRKSRC}

PYTHON=${MODPY_BIN} ${MODPY_BIN}

CC=${PREFIX}/bin/egcc ./waf configure --prefix=${PREFIX} --mandir=${PREFIX}/man

you'd want something like "${MODPY_BIN} ./waf configure [...]"