Re: portimport: reminder to commit db/user.list

2018-05-29 0:54 GMT+03:00 Stuart Henderson <stu@spacehopper.org>:
> On 2018/05/28 19:22, Vadim Zhukov wrote:
>> 28 мая 2018 г. 15:39:29 GMT+03:00, Stuart Henderson <stu@spacehopper.org> пишет:
>> >Does anyone have a port to import with a new uid/gid they could test
>> >this with please? :-)
>> >
>> >Index: portimport
>> >===================================================================
>> >RCS file: /cvs/ports/infrastructure/bin/portimport,v
>> >retrieving revision 1.5
>> >diff -u -p -r1.5 portimport
>> >--- portimport 9 Feb 2014 15:10:49 -0000 1.5
>> >+++ portimport 28 May 2018 12:38:36 -0000
>> >@@ -62,6 +62,7 @@ cvs -n -d$cvsroot import ports/$pkgpath
>> > read ans?'Does this look correct? [y/n] '
>> > if [[ $ans == +(y|Y) ]]; then
>> > cvs -d$cvsroot import ports/$pkgpath $user ${user}_$timestamp
>> >+ grep -q "^@new" pkg/P* && echo "New users/groups, remember to commit
>> >infrastructure/db/user.list!"
>> > cd "$portsdir/${pkgpath%/*}"
>> > cvs -d$cvsroot update -AdP ${pkgpath##*/}
>> > echo "Don't forget to commit the ${pkgpath%/*}/Makefile when you're
>> >done!"
>>
>> This looks like more a job for portcheck, which is run by portimport anyway. I'll cook a tweak ASAP.
>> --
>> WBR,
>> Vadim Zhukov
>
> The presence is checked in ports tools now, this is just a reminder to
> actually commit it. portcheck is the wrong place for that, it wants to
> be right at the end with the "commit the makefile" reminderso it's
> not forgotten.

I've got your point, thanks. Please disregard the portcheck diff on
ports@ then, and sorry for the noise.

--
WBR,
Vadim Zhukov