Re: portimport: reminder to commit db/user.list

On Mon, May 28, 2018 at 07:22:29PM +0300, Vadim Zhukov wrote:
> 28 мая 2018 г. 15:39:29 GMT+03:00, Stuart Henderson <stu@spacehopper.org> пишет:
> >Does anyone have a port to import with a new uid/gid they could test
> >this with please? :-)
> >
> >Index: portimport
> >===================================================================
> >RCS file: /cvs/ports/infrastructure/bin/portimport,v
> >retrieving revision 1.5
> >diff -u -p -r1.5 portimport
> >--- portimport 9 Feb 2014 15:10:49 -0000 1.5
> >+++ portimport 28 May 2018 12:38:36 -0000
> >@@ -62,6 +62,7 @@ cvs -n -d$cvsroot import ports/$pkgpath
> > read ans?'Does this look correct? [y/n] '
> > if [[ $ans == +(y|Y) ]]; then
> > cvs -d$cvsroot import ports/$pkgpath $user ${user}_$timestamp
> >+ grep -q "^@new" pkg/P* && echo "New users/groups, remember to commit
> >infrastructure/db/user.list!"
> > cd "$portsdir/${pkgpath%/*}"
> > cvs -d$cvsroot update -AdP ${pkgpath##*/}
> > echo "Don't forget to commit the ${pkgpath%/*}/Makefile when you're
> >done!"
>
> This looks like more a job for portcheck, which is run by portimport anyway. I'll cook a tweak ASAP.

Well, I've never used either portcheck nor portimport but from my understanding
it makes more sense to have this in portimport because that's a reminder for a
commit, not a syntaxt or whatever issue.

--
Antoine