Wednesday, May 30, 2018

Re: Update: audio/cmus ffmpeg fixes (MAINTAINER)

Klemens Nanni wrote:

> On Sat, May 26, 2018 at 01:11:08PM +0200, Donovan Watteau wrote:
> > The following diff updates the ffmpeg plugin used by audio/cmus:
> > http://www.dwatteau.fr/tmp/cmus_ffmpeg_update.diff
> Looks good.

> > The current code is giving an increasing number of deprecated warnings,
and
> > it can also crash in some cases. So I've backported the most important
> > changes from upstream HEAD.
> Thanks. Can you show us how to reproduce a crash?

Sure, I can reproduce it with the file given in this issue:
https://github.com/cmus/cmus/issues/204

And I can confirm that the crash disappears with the above diff.

Thanks.

> > Tested on amd64, macppc, loongson with various formats (played or not
> > played by the ffmpeg plugin).
> No problems running it as usual on my X250.

No comments:

Post a Comment