Re: games/openrct2 missing dependencies?

On 06/28/18 13:52, Stuart Henderson wrote:
> On 2018/06/28 19:12, Solene Rapenne wrote:
>> Brian Callahan writes:
>>
>>> On 6/28/2018 12:48 PM, Solene Rapenne wrote:
>>>> when I start openrct2 the first time without the configuration file
>>>> modified to point to the assets of the game I get this in my terminal:
>>>>
>>>> $ openrct2
>>>> which: zenity: Command not found.
>>>> which: kdialog: Command not found.
>>>> which: zenity: Command not found.
>>>> which: kdialog: Command not found.
>>>> which: zenity: Command not found.
>>>> which: kdialog: Command not found.
>>>> (undefined string)
>>>> An RCT2 install directory must be specified! Please edit "game_path" in
>>>> /home/solene/.config/OpenRCT2/config.ini.
>>>>
>>>>
>>>>
>>>> If I modifiy game_path in the config file, starting openrct2 doesn't
>>>> trigger any issue.
>>>>
>>>> Is it worth fixing?
>>>>
>>> This has come up before. It seems crazy to me to force openrct2, which
>>> has relatively small dependencies, to depend on gigantic pieces of gnome
>>> or kde for a one-time startup that, as you see, the game will tell you
>>> how to manually set up. The openrct2 pkg/README also explains how to set
>>> things up. Maybe the pkg/README could be better. I'm open to suggestions.
>>>
>>> If you happen to be using gnome or kde, great. One of those dialog
>>> programs will be used. For the rest of us, we have pkg/README.
>>>
>>> ~Brian
>> I don't have any problem with keeping the game with small deps, as that
>> doesn't prevent a message to be displayed and that pkg/README exists. I
>> understand that it was a choice, sorry for the fuss.
>>

No worries--no fuss. I think last time it was brought up in private so
I'm happy to have this in the archives.

> It's a bit nicer like this .. There's still an "undefined string" but it
> no longer looks like bad packaging.

Sure, that's a good idea.

~Brian

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/openrct2/Makefile,v
> retrieving revision 1.9
> diff -u -p -r1.9 Makefile
> --- Makefile 27 Jun 2018 21:03:48 -0000 1.9
> +++ Makefile 28 Jun 2018 17:52:12 -0000
> @@ -7,7 +7,7 @@ V = 0.1.2
> COMMENT = open source re-implementation of RollerCoaster Tycoon 2
> DISTNAME = openrct2-${V}
> CATEGORIES = games x11
> -REVISION = 0
> +REVISION = 1
>
> HOMEPAGE = https://openrct2.org/
> MAINTAINER = Brian Callahan <bcallah@openbsd.org>
> Index: patches/patch-src_openrct2-ui_UiContext_Linux_cpp
> ===================================================================
> RCS file: patches/patch-src_openrct2-ui_UiContext_Linux_cpp
> diff -N patches/patch-src_openrct2-ui_UiContext_Linux_cpp
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-src_openrct2-ui_UiContext_Linux_cpp 28 Jun 2018 17:52:12 -0000
> @@ -0,0 +1,19 @@
> +$OpenBSD$
> +
> +Index: src/openrct2-ui/UiContext.Linux.cpp
> +--- src/openrct2-ui/UiContext.Linux.cpp.orig
> ++++ src/openrct2-ui/UiContext.Linux.cpp
> +@@ -250,11 +250,11 @@ namespace OpenRCT2 { namespace Ui
> + {
> + // Prefer zenity as it offers more required features, e.g., overwrite
> + // confirmation and selecting only existing files
> +- if (Execute("which zenity", executablePath) == 0)
> ++ if (Execute("which zenity 2> /dev/null", executablePath) == 0)
> + {
> + return DIALOG_TYPE::ZENITY;
> + }
> +- if (Execute("which kdialog", executablePath) == 0)
> ++ if (Execute("which kdialog 2> /dev/null", executablePath) == 0)
> + {
> + return DIALOG_TYPE::KDIALOG;
> + }